Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filestore: Close files correctly when concatenating uploads #1239

Merged
merged 3 commits into from
Jan 16, 2025
Merged

filestore: Close files correctly when concatenating uploads #1239

merged 3 commits into from
Jan 16, 2025

Conversation

nervtech
Copy link
Contributor

Provided one solution to issue #1238

@Acconut Acconut changed the title filestore: Add a method to ensure merged chunk files are properly closed filestore: Close files correctly when concatenating uploads Jan 16, 2025
Acconut
Acconut approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! I pushed two additional changes and now this is ready to be merged.

@Acconut Acconut linked an issue Jan 16, 2025 that may be closed by this pull request
When using filestore as the storage backend, why are chunk files not closed during the merging phase? #1238
Closed
@Acconut Acconut merged commit 7178845 into tus:main Jan 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using filestore as the storage backend, why are chunk files not closed during the merging phase?
2 participants
@nervtech @Acconut